Questions about performance

Jip · 26 Aug 2021, 21:37

oh no

I'll look into that too - thank you for mentioning it.

Jip · 27 Aug 2021, 06:31

@crotalus It is fixed - thank you for reporting it! This was also the issue @excelsior (discord) described and @Crotalus experienced during that replay.

@zwierzak The replay desyncs for me and that happens to be MaximusXXX . Can you describe what happened?

Jip · 27 Aug 2021, 08:37

@utopian Thanks to KionX we may have found out what caused this crash. It will not be part of the next patch because its deadline is too close - but we'll certainly look at it. Again, thank you for reporting it.

snoog · 27 Aug 2021, 15:18

@jip said in Questions about performance:

@crotalus It is fixed - thank you for reporting it! This was also the issue @excelsior (discord) described and @Crotalus experienced during that replay.

Is the fix live on the dev branch right now? Just wondering if I should warn people or not when hosting games.

Jip · 27 Aug 2021, 15:21

The fix with the mantis is live - yes

zwierzak · 27 Aug 2021, 17:32

I failed to reproduce MaximusXXX's error and the game now desyncs for me, too. Probably because of the Mantis fix.
However, while testing just now, I found new problems:

Game: #15195914
Timestamp: 20:00
Issue: UEF T1 Attack Bomber seems to do very little damage

Game: #15195914
Timestamp: 28:00
Issue: Cybran T2 Naval Support Factory auto-repairs VERY quickly

Log isn't much help, as I didn't have debug enabled.

Jip · 27 Aug 2021, 17:43

@zwierzak

Game: #15195914
Timestamp: 20:00
Issue: UEF T1 Attack Bomber seems to do very little damage

This is a known issue, it has to do with a change unrelated to performance. The Janus is hit hard too by that same change. Keyser is going to look at it this weekend.

Game: #15195914
Timestamp: 28:00
Issue: Cybran T2 Naval Support Factory auto-repairs VERY quickly

I'll look at it - thanks for reporting it.

Saver · 29 Aug 2021, 12:00

Hello Jip, thank you very much for your work in the forum and the game. Thanks also to the team. I think it's great how the community helps with every question. That's what I wish for in every game.

Regarding the question, I have noticed a drop in performance in the game so far (1 - 2 players vs 4 AIs)

Jip · 29 Aug 2021, 12:13

There is an issue with the current faf develop that was introduced yesterday. It causes a lot of warnings. It is fixed in about an hour .

Jip · 29 Aug 2021, 12:31

@Saver it should be stable now again .

Saver · 30 Aug 2021, 15:56

Thanks

Saver · 4 Sept 2021, 12:27

Hallo zusammen, ich hatte zwei Patien hintereinander diesen Fehler,
...

EXCEPTION_ACCESS_VIOLATION (0xc0000005) at address 0x0050dfd8
attempted to read memory at 0x0000005c

Program : C:\ProgramData\FAForever\bin\ForgedAlliance.exe
Cmd line arguments : /init init.lua /nobugreport /log C:\ProgramData\FAForever\logs\game_15248616.log /gpgnet 127.0.0.1:51021 /mean 1366.81 /deviation 289.003 /savereplay gpgnet://127.0.0.1:60541/15248616/Saver.SCFAreplay /country DE /numgames 8

Callstack:
Unknown symbol (address 0x0050dfd8)
Unknown symbol (address 0x0068af40)
Unknown symbol (address 0x2046e5fb)

Last 100 lines of log...

warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
debug: Current gametime: 01:32:30
debug: Current gametime: 01:33:00
debug: Current gametime: 01:33:30
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
info: CWldSession::DoBeat() unknown entity id (0x2ff0274b) supplied in a pose update.
debug: Current gametime: 01:34:00
warning: Scanning: unit ["xsl0307"] has no MaxWeaponRange - "RNGAI Response BaseRestrictedArea"
warning: Scanning: unit ["xsl0307"] has no MaxWeaponRange - "RNGAI Response BaseRestrictedArea"
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
debug: Current gametime: 01:34:30
warning: Scanning: unit ["xsl0307"] has no MaxWeaponRange - "RNGAI Trueplatoon Large"
warning: Scanning: unit ["xsl0307"] has no MaxWeaponRange - "RNGAI Trueplatoon Large"
info: CWldSession::DoBeat() unknown entity id (0x2ff029fa) supplied in a pose update.
warning: Scanning: unit ["xsl0304"] has no MaxWeaponRange - "RNGAI Trueplatoon Large"
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
debug: Current gametime: 01:35:00
warning: Scanning: unit ["xsl0307"] has no MaxWeaponRange - "RNGAI Trueplatoon Large"
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
warning: GetResource: Invalid name ""
info: UI_MakeSelectionSet 1
debug: Current gametime: 01:35:30
debug: Current gametime: 01:36:00
info: CWldSession::DoBeat() unknown entity id (0x2ff02abc) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02abd) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02abe) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ac1) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ac5) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ac7) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ac8) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02a90) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ace) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02acf) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ad0) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ad2) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ad3) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ad4) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02ada) supplied in a pose update.
debug: Loading module '\000/projectiles/aifquantumwarhead02/aifquantumwarhead02_script.lua\000'
info: Hooked /projectiles/aifquantumwarhead02/aifquantumwarhead02_script.lua with /mods/rks_explosions/hook/projectiles/aifquantumwarhead02/aifquantumwarhead02_script.lua
warning: ACU kill detected. Rating for ranked games is now enforced.
debug: Loading module '\000/effects/quantumwarhead/quantumwarheadeffect01_script.lua\000'
info: Sending game result: 8 score 1
info: GAMERESULT : \000score 1
info: Sending game result: 3 defeat -10
info: GAMERESULT : \000defeat -10
debug: Loading module '\000/projectiles/adfgraviton01/adfgraviton01_script.lua\000'
warning: Error running lua script: ...ogramdata\faforever\gamedata\lua.nx5\lua\platoon.lua(4005): attempt to call method `GetLocationCoords' (a nil value)
stack traceback:
...ogramdata\faforever\gamedata\lua.nx5\lua\platoon.lua(4005): in function <...ogramdata\faforever\gamedata\lua.nx5\lua\platoon.lua:3995>
info: CWldSession::DoBeat() unknown entity id (0x2ff02abc) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02abd) supplied in a pose update.
info: UI_Lua import("/lua/ui/game/confirmunitdestroy.lua").ConfirmUnitDestruction(false)
debug: Current gametime: 01:36:30
info: CWldSession::DoBeat() unknown entity id (0x2ff02b78) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02b7b) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02b7c) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02b7d) supplied in a pose update.
info: CWldSession::DoBeat() unknown entity id (0x2ff02b7f) supplied in a pose update.

Das Spiel lief so lange gut, bis ich die Units von der besiegten ACU übergeben bekommen habe.

Spieleinstellung:
Team 1
1 xPlayer 3x Sorian AI VS 2 x RNGAI 2 x Sorian AI

Mods:
RKS Explosion
Graphicenhancement mod v1.1
RNGAI
Saver Fatboy2

Ich hoffe der Bericht hilft evtl. für den Patch.

Und nochmals vielen Dank für eure Arbeit an dem Game.

Jip · 9 Apr 2021, 14:58

Thank you for sharing it, this is a known issue and is being solved .

edit: it is the same issue described here:

https://github.com/FAForever/fa/pull/3398#issuecomment-910145340

And the source is found.

Saver · 5 Sept 2021, 06:35

TOP und viel Erfolg.

zwierzak · 10 Sept 2021, 20:19

@Jip In https://replay.faforever.com/15287785 , somebody said that the explosions from UEF T2 Destroyer shots looked like the ones from a battleship. Might apply to UEF T2 PD, too.

Jip · 10 Sept 2021, 22:00

Yes - that is part of the change by @keyser if I am correct. It is intended, to give the unit more 'wow'.

keyser · 11 Sept 2021, 09:10

I didn't change the explosion fx, just the decals

Jip · 11 Sept 2021, 21:03

Jip · 12 Sept 2021, 19:28

I'll look into that too tonight .

On another note: a milestone! The benchmark map that we'll use is made by Marlo and has recently been finished! You can find the trailer here: https://www.youtube.com/watch?v=6-F_-HXgO_M

The trailer was made on the regular branch. As you can see the game starts to stutter more and more as it continuous. Our job is done when we can record this trailer with no stutters at all.

Jip · 16 Sept 2021, 09:38

Upcoming Sunday (yes - it got moved slightly) the new patch will be live! This means that we're merging the develop branch with the standard branch that everyone plays by default, including ladder.

Soon after new PRs will merge into the develop branch with more optimizations and features. You can read up about some of them in this post or by checking the pull requests on Github. Please keep playing the develop branch as it provides us with important feedback on whether the changes help and are appreciated in general. It is a solid approach to contributing to FAF while literally just playing the game and reporting back.

As an example, with thanks to @WhenDayBreaks and @snagglefox some critical errors were found and fixed, including a few that were present in the standard branch too. The ping-preventing code got re-implemented and is now the same as you had before, but without the ability to abuse it in the name of someone else as easily. I can keep going with examples - know that your feedback is appreciated and I hope you all keep them coming in the future.