It is great to see so much effort being put into the game, whether that is through a mod or otherwise
But I wish you followed the best practices with regards to hooking existing Lua code. At the moment instead of hooking the mod overrides several critical files / classes, such as:
/lua/sim/unit.lua
and /lua/defaultunits.lua
, overwriting the code basis that all units rely on
/lua/sim/defaultprojectiles.lua
and /lua/defaultantiprojectiles.lua
, overwriting the code basis that a lot of projectiles rely on
/lua/ui/game/unitview.lua
, overwriting the code of the unit info as you hover over a unit and all interactions with it
/lua/ui/game/construction.lua
, overwriting the code of the construction menu and all interactions with it
As a consequence, if we'd make any change to any of these files / classes then your mod will simply overwrite them. Other files / classes may rely on those changes, and error out accordingly.
One such example is the spread attack alternative, which adds one function to the unit class. That function would not exist in your mod. And therefore the code would error out. That change will be released on the 24th, removing the old spread attack implementation. And the alternative won't work in your mod the way it is setup now.
As an example, take the second item of the modification-resources channel on Discord:
And specifically:
Which explains you exactly how to do it, along with some good fashioned humor of Balthazar. It is a good read, even for those that are not into making mods
As you mention copyrights at the end of your post - the repository has no license. Some files have a specific header indicating a license, such as with the navigational mesh. When no such license exists the default copyright laws apply, which you can read about here:
Some of the files that you copied from top to bottom are taken from the repository. You technically don't have the rights to distribute those through the vault. To quote the license you agree on when uploading content to the vault:
In particular, you represent and warrant that the User Generated Content was originally created by you (or, with respect to a User Generated Content to which others contributed besides you, by you and the other contributors, and in such case that you have the right to submit such content on behalf of those other contributors).
You can read the vault rules / license here:
I don't mind that you're taking files that I worked on. The moral of my response however is to encourage you to properly hook the files you're working with. That way your mod will not break the game starting on the 24th of August. And your mod will only contain the code that it needs to function, reducing the copyright issues mentioned above to a minimum.
And with all of that said - I'd love to know how you fixed beam weapons occasionally missing a target. A lot of attempts have been made in the past and none of them really fixed the problem