FAForever Forums
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Login

    Questions about performance

    Scheduled Pinned Locked Moved
    General Discussion
    19
    70
    9.7k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • JipJ
      Jip @snoog
      last edited by Jip

      @snagglefox Great to hear!

      I can't ping after my ACU was killed. Is this a bug or new feature?
      Sadly this is neither a bug nor a feature. Pinging after dying is disabled because of a potential exploit. For more information, read this PR: https://github.com/FAForever/fa/issues/2259

      Cybran hive drones are completely MIA. I only see the beams.
      🤔 , the drones being missing is a bug - not sure what causes it yet. I'll make sure to investigate it before the patch hits in September.

      edit: about the drones missing, could you describe what you did right before it happened? I have a hard time re-producing it.

      A work of art is never finished, merely abandoned

      S 1 Reply Last reply Reply Quote 0
      • S
        snoog @Jip
        last edited by

        @jip

        Sadly this is neither a bug nor a feature. Pinging after dying is disabled because of a potential exploit. For more information, read this PR: https://github.com/FAForever/fa/issues/2259

        Ah ok. Thanks for the info!

        🤔 , the drones being missing is a bug - not sure what causes it yet. I'll make sure to investigate it before the patch hits in September.

        edit: about the drones missing, could you describe what you did right before it happened? I have a hard time re-producing it.

        I probably should have mentioned those were allied hives. I was already dead. So maybe being dead or them being an ally's has something to do with it?

        arma473A 1 Reply Last reply Reply Quote 0
        • arma473A
          arma473 @snoog
          last edited by arma473

          @snagglefox Sadly this is neither a bug nor a feature. Pinging after dying is disabled because of a potential exploit. For more information, read this PR: https://github.com/FAForever/fa/issues/2259

          This is not a good reason to take away everyone's ability to ping after death.

          1 - nobody is forced to allow observers in a match

          2 - observers can cheat anyway if they're on voice chat with a player

          If people want to cheat they can cheat. Observers using a console command to place markers in the game in real-time would leave evidence of cheating in everyone's replay file. Doing it through voice chat would be basically undetectable.

          Nobody is going to cheat in a way that leaves evidence so blatantly. And if they did, we would catch them.

          This is NOT A PROBLEM but taking away the ability of dead players to participate in the game is a BIG PROBLEM.

          I can't even queue for ladder or TMM while a game is going on, and now you're telling me I can't even ping my teammates while I wait for the match to end? That's nonsense. Total nonsense. "Fixing" something that was never a problem in the first place. UN-FIX this!

          1 Reply Last reply Reply Quote 2
          • FemtoZettaF
            FemtoZetta
            last edited by

            Yeah, either this is described poorly and it's not just observers that can do it but anyone who died, or it's really not a problem at all, because observers always could cheat in many ways (like VC) and they really never did that by using pings.

            1 Reply Last reply Reply Quote 3
            • JipJ
              Jip
              last edited by

              The decision to disable the markers was made by two council members (if I recall correct) last year December, see also the PR where the change was made from that time:

              • https://github.com/FAForever/fa/pull/3240

              If you do not agree with this change, please make a new topic. It is unrelated to this topic about performance (and stability).

              If people want to cheat they can cheat. Observers using a console command to place markers in the game in real-time would leave evidence of cheating in everyone's replay file. Doing it through voice chat would be basically undetectable.
              This is not the consequence of the exploit. I'm leaving it vague on purpose because I do not want to give it more attention than it has to have.

              A work of art is never finished, merely abandoned

              1 Reply Last reply Reply Quote 0
              • C
                Crotalus
                last edited by Crotalus

                Played a fafdevelop game where ACU upgrade after it should finish got stuck and acu was constantly -7 mass.

                (I was assisting ACU with cybran t1 assault bot)

                This error popped up in the log:

                warning: Error running OnStartBuild script in Entity url0107 at 25034d08: ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(901): attempt to call method IsUnitState' (a nil value) stack traceback: ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(901): in function UpdateAssistersConsumption'
                ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(971): in function UpdateConsumptionValues' ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(852): in function SetActiveConsumptionActive'
                ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(2570): in function <...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua:2533>

                JipJ 1 Reply Last reply Reply Quote 0
                • JipJ
                  Jip @Crotalus
                  last edited by Jip

                  @crotalus said in Questions about performance:

                  Played a fafdevelop game where ACU upgrade after it should finish got stuck and acu was constantly -7 mass.

                  (I was assisting ACU with cybran t1 assault bot)

                  This error popped up in the log:

                  warning: Error running OnStartBuild script in Entity url0107 at 25034d08: ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(901): attempt to call method IsUnitState' (a nil value) stack traceback: ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(901): in function UpdateAssistersConsumption'
                  ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(971): in function UpdateConsumptionValues' ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(852): in function SetActiveConsumptionActive'
                  ...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua(2570): in function <...gramdata\faforever\gamedata\lua.nx5\lua\sim\unit.lua:2533>

                  Hi Crotalus, can you share the entire log and the replay ID?

                  edit: the error you provided is from a Mantis.

                  A work of art is never finished, merely abandoned

                  C 1 Reply Last reply Reply Quote 0
                  • C
                    Crotalus @Jip
                    last edited by

                    @jip game_15190526.log

                    Z JipJ 2 Replies Last reply Reply Quote 1
                    • JipJ
                      Jip
                      last edited by

                      And timestamp as to when it roughly happened? And to what player?

                      A work of art is never finished, merely abandoned

                      1 Reply Last reply Reply Quote 0
                      • JipJ
                        Jip
                        last edited by Jip

                        Ah, I think I understand what happened here. Thank you for sharing.

                        edit: found and understood the issue.

                        A work of art is never finished, merely abandoned

                        1 Reply Last reply Reply Quote 0
                        • BlackYpsB
                          BlackYps
                          last edited by BlackYps

                          I'm still not sure if this applies to games with observers off (i.e. most of the games) at all.

                          Edit: woops, meant to post this in the other thread, sorry

                          1 Reply Last reply Reply Quote 1
                          • JipJ
                            Jip
                            last edited by

                            @BlackYps You can continue the other discussion here:

                            • https://forum.faforever.com/topic/2461/ping-after-death-could-be-removed

                            A work of art is never finished, merely abandoned

                            1 Reply Last reply Reply Quote 0
                            • Z
                              zwierzak @Crotalus
                              last edited by

                              @Jip In the same game that Crota reported, MaximusXXX said at 38:21 that he was able to build t2 navy despite the HQ being dead.

                              game_15190526.log

                              1 Reply Last reply Reply Quote 0
                              • JipJ
                                Jip
                                last edited by Jip

                                oh no 🙂

                                I'll look into that too - thank you for mentioning it.

                                A work of art is never finished, merely abandoned

                                1 Reply Last reply Reply Quote 0
                                • JipJ
                                  Jip @Crotalus
                                  last edited by Jip

                                  @crotalus It is fixed - thank you for reporting it! This was also the issue @excelsior (discord) described and @Crotalus experienced during that replay.

                                  @zwierzak The replay desyncs for me and that happens to be MaximusXXX . Can you describe what happened?

                                  A work of art is never finished, merely abandoned

                                  S 1 Reply Last reply Reply Quote 0
                                  • JipJ
                                    Jip @Utopian
                                    last edited by

                                    @utopian Thanks to KionX we may have found out what caused this crash. It will not be part of the next patch because its deadline is too close - but we'll certainly look at it. Again, thank you for reporting it.

                                    A work of art is never finished, merely abandoned

                                    1 Reply Last reply Reply Quote 0
                                    • S
                                      snoog @Jip
                                      last edited by

                                      @jip said in Questions about performance:

                                      @crotalus It is fixed - thank you for reporting it! This was also the issue @excelsior (discord) described and @Crotalus experienced during that replay.

                                      Is the fix live on the dev branch right now? Just wondering if I should warn people or not when hosting games.

                                      1 Reply Last reply Reply Quote 0
                                      • JipJ
                                        Jip
                                        last edited by

                                        The fix with the mantis is live - yes

                                        A work of art is never finished, merely abandoned

                                        1 Reply Last reply Reply Quote 0
                                        • Z
                                          zwierzak
                                          last edited by zwierzak

                                          I failed to reproduce MaximusXXX's error and the game now desyncs for me, too. Probably because of the Mantis fix.
                                          However, while testing just now, I found new problems:

                                          Game: #15195914
                                          Timestamp: 20:00
                                          Issue: UEF T1 Attack Bomber seems to do very little damage

                                          Game: #15195914
                                          Timestamp: 28:00
                                          Issue: Cybran T2 Naval Support Factory auto-repairs VERY quickly

                                          Log isn't much help, as I didn't have debug enabled. 😞

                                          JipJ 1 Reply Last reply Reply Quote 0
                                          • JipJ
                                            Jip @zwierzak
                                            last edited by

                                            @zwierzak

                                            Game: #15195914
                                            Timestamp: 20:00
                                            Issue: UEF T1 Attack Bomber seems to do very little damage

                                            This is a known issue, it has to do with a change unrelated to performance. The Janus is hit hard too by that same change. Keyser is going to look at it this weekend.

                                            Game: #15195914
                                            Timestamp: 28:00
                                            Issue: Cybran T2 Naval Support Factory auto-repairs VERY quickly

                                            I'll look at it - thanks for reporting it.

                                            A work of art is never finished, merely abandoned

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post