RK's Explosion mod no longer supported?

Hazard

Perhaps I'm not good at looking, but I didn't see this anywhere else. RK's mod has been working well for me until I recently updated the client and now it prevents ACUs from spawning in. Anyone know what may be causing this or is the mod just no longer supported by the current version? Thanks.

Jip

I'd love to fix it for you but I can't find the license of the mod. Therefore I can't upload a fixed version to the vault. Looking at the original post here:

https://forums.faforever.com/viewtopic.php?f=41&t=6813

I can't ping RK4000 which means he has no forum account. Maybe I can ask @speed2 and / or @Sheeo for permission to upload a fixed version?

edit: and perhaps add a license to the mod so that we won't have to ping you in the future again

zhanghm18

@jip It would be great if it could be repaired! Thank you very much

speed2

Here's the repo for the mod https://github.com/RK4000/RK-s-Explosions
IIRC I've uploaded the latest version to the mod vault

So if you make a PR with the fixes, I can make a new release and upload it.

Doompants

Nice! Before the recent bug, we found it was causing desyncs too, but it didn't sound like an active project, so thanks for looking into it.

Some of the effects were pretty intense, but this mod is worth it alone for the oil slicks after a huge naval battle.

Jip

@speed2 This makes it functional again:

https://github.com/RK4000/RK-s-Explosions/pull/26

There are other errors, but they aren't game breaking.

@Doompants the way the mod is setup - I wouldn't trust it together with other mods that change large aspects of the game.

Druark

Sadly seems that even with the linked fix, this is still broken (or maybe broken again by another update) as it gives an Access violation immediately upon loading.
game_20861403.log

Jip

The name of the repository doesn't match the expected name of the mod. If you rename the mod folder to rks_explosions then it should work

Druark

Ah! Always something I forget to check. That fixed it.

Just to note, the one on the Vault is still V12 so it'll still be broken. Was it intended that this was updated too or was the license an issue still?

Regardless, the support is much appreciated.

JuggernautOfWar

I can confirm the mod version distributed through the vault is still game-breaking. ACU will not spawn at the beginning of the game.

I haven't yet tried the github version linked above, but I'm not sure I trust the mod will get along with Total Mayhem and BlackOps-Unleashed also running. I wish there were another effects mod that was maybe a bit simpler to keep updated and compatible with other mods.

Dozhmat

Not working again. I tied V13 with renaming the mod folder to rks_explosions and still nothing - stuck on the loadscreen at the beginning.

Saver

Could the mod be repaired and re-uploaded? Is this possible?

Rowey

@saver not unless the mod author gave permission to someone to do this

BlackYps

There should be a license file in the github repo of the mod

MostLostNoob

@blackyps Sadly, there's not. Nor is there any copyright info in the mod_info.lua file.

Dozhmat

Can somebody call to author of the mod?

BlackYps

Historically speed2 merged Pull requests that were made against the mod repo. If anyone is missing the link, this is the one: https://github.com/RK4000/RK-s-Explosions