Black Screen with mod v6 'Advanced Target Priorities EVO'

SealingSatyr511

a hotfix should be available very soon.

I found some side effects relative to gameprefs and the preset management.
May occurs at startup when the prioSettings are unknown, nil error that cause crash.
and an uppercase bug on the preset filename. Stogo1_1.lua => stogo1_1.lua.
Also, a part of the safety code was missing.

i checked from scratch, got errors with use cases, critical, but never a black screen.
Actually the fix is ok. it solves the issues.
the code is way more robust now but need another testing iteration.

nomads

- ---Is the following content related to the capitalization issue you mentioned?
- -- from init_faf.lua
- --- Lowers the strings of a hash-based table, crashes when other type of keys are used (integers, for example)
- local function LowerHashTable(t)
- ```
local o = { }
```
- ```
for k, v in t do 
```
- ```
    o[StringLower(k)] = v 
```
- ```
end
```
- ```
return o
```
- end
- -- mods that have been integrated, based on folder name
- local integratedMods = { }
- integratedMods = LowerHashTable(integratedMods)
- -- convert all mod folder name keys to lower case to prevent typos
- deprecatedMods = LowerHashTable(deprecatedMods)
- -- typical FAF packages
- local allowedAssetsNxy = { }
- allowedAssetsNxy = LowerHashTable(allowedAssetsNxy)
- -- typical FA packages
- local allowedAssetsScd = { }
- allowedAssetsScd = LowerHashTable(allowedAssetsScd)

SealingSatyr511

Hot fix is available

https://forum.faforever.com/post/66448

I tested from scratch, fresh mod and default GamePrefs. I don't have issue or error hidden behind a tree.
I hope it solves the game to freeze at startup some player have encountered on fresh install.

Sorry for the inconvenience

nomads

序列 01_1 00_00_00-00_00_30.gif

I just tried the latest version of version 7.

SealingSatyr511

how is your gamePrefs ?
\AppData\Local\Gas Powered Games\Supreme Commander Forged Alliance

the structure should be like :

AdvancedPriotities = {
                windowHeight = 140,
                posY = 912,
                AttackConstructionLeftValue = 495,
                AttackOrdersLeftValue = 1357,
                Preset = 'strogo1_1',
                FactoryConstructionRightValue = 1540,
                buttonLayoutSeparate = {
                    {
                        'false',
                        'ACU',
                        'false',
                        'false',
                        'Bships',
                        'Cruiser'
                    },
                    {
                        'false',
                        'Destros',
                        'ACU',
                        'Factory',
                        'false',
                        'false'
                    },
                    {
                        'Engies',
                        'Arty',
                        'EXP',
                        'false',
                        'ACU',
                        'false'
                    }
                },
                windowWidth = 220,
                hideAbilities = false,
                posX = 2276,
                FactoryConstructionLeftValue = 254,
                showSeparateWindow = true,
                lockSeparateWindow = false,
                FactoryOrdersLeftValue = 1542,
                AttackConstructionRightValue = 1355
            },

nomads

Preset = 'strogo1_1',

This command doesn't seem to be automatically added

SealingSatyr511

Can you add it and have a check ?
i tried multiple scenario where the entries in GamePrefs were missing, and the crud operation works on the preset filename.

nomads

After the instruction is added, it's okay
thank you very much.

SealingSatyr511

if it fix the prb by adding this entry, that mean i must verify the mod pref of the profile and if it is not compliant, delete and rebuilt it on the fly, to prevent any bad old data structure.

nomads

unable to add commands, related to Windows system permissions?

SealingSatyr511

well, i will do a fix to check the gamePrefs as i described. It can occurs some structure corruption after installing wrong update etc...

SealingSatyr511

This post is deleted!

nomads

Take care of yourself, good night

SealingSatyr511

@nomads not sure it was due to that. i prefer do a better control of any existing entries in gameprefs first.

The v7 contains several major fixes also.

SealingSatyr511

Thank you

SealingSatyr511

1.0.4 - Fix
-Added a test plan execution at startup to prevent GamePrefs issues
(version 8 in the vault)

magge

With v8 I do not get any black screen anymore, but unfortunately, I do not get any bottom build panel when I select any unit. (no other mods active).

warning: Error running '/lua/ui/game/gamemain.lua:OnSelectionChanged': ...\advanced target priorities evo\modules\settings.lua(802): perform arithmetic on expected but got nil
         stack traceback:
         	...\advanced target priorities evo\modules\settings.lua(802): in function `ApplyCoordinatesToPanels'
         	...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1881): in function <...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua:1875>
         	...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1675): in function `SetAvailableOrders'
         	...aforever\1\gamedata\lua.nx2\lua\ui\game\gamemain.lua(702): in function <...aforever\1\gamedata\lua.nx2\lua\ui\game\gamemain.lua:625>
warning: Error running '/lua/ui/game/gamemain.lua:OnSelectionChanged': ...\advanced target priorities evo\modules\settings.lua(802): perform arithmetic on expected but got nil
         stack traceback:
         	...\advanced target priorities evo\modules\settings.lua(802): in function `ApplyCoordinatesToPanels'
         	...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1881): in function <...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua:1875>
         	...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1675): in function `SetAvailableOrders'
         	...aforever\1\gamedata\lua.nx2\lua\ui\game\gamemain.lua(702): in function <...aforever\1\gamedata\lua.nx2\lua\ui\game\gamemain.lua:625>

SealingSatyr511

Ok.
can you share your GamePrefs "advancedpriotities" ?
and what is your current adapter resolution ?
Do you use a second monitor ? if yes, left or right display ?

magge

The 'advancedpriotities' entry in the Game.prefs:

            AdvancedPriotities = {
                windowHeight = 140,
                posY = 500,
                AttackConstructionLeftValue = 600,
                AttackOrdersLeftValue = 50,
                Preset = 'strogo1_1',
                FactoryConstructionRightValue = 1400,
                buttonLayoutSeparate = {
                    { },
                    { },
                    { }
                },
                windowWidth = 120,
                FactoryOrdersLeftValue = 50,
                posX = 50,
                FactoryConstructionLeftValue = 600,
                showSeparateWindow = false,
                lockSeparateWindow = false,
                hideAbilities = false,
                AttackConstructionRightValue = 1400
            },

Primary monitor: 2560 x1440 I use only one monitor for gaming. SC runs only on the main screen.

@SealingSatyr511 said in Black Screen with mod v6 'Advanced Target Priorities EVO':

Do you use a second monitor ? if yes, left or right display ?

Yes, bottom.

Edit: BTW, there is a spelling mistake:

For 'advancedpriotities' is the "r" missing; 'advancedpriorities'

SealingSatyr511

The gamePrefs is ok, yes it's advancedpriotities (without the r). It's easier for the dev to find in the gameprefs. it's native code of the old 1.1.

here is the code that fails :

-- check the serapate targeting window position
local separateWindow = import("/lua/ui/game/orders.lua").GetSeparateWindow()
local tableRez = mysplit(Prefs.GetFromCurrentProfile('options').primary_adapter,',')
if (prioritySettingsPrefs.posX > tonumber(tableRez[1])-207) or  
   (prioritySettingsPrefs.posY > tonumber(tableRez[2])-145) then    
        separateWindow.Left:Set(DefaultPosX)
        separateWindow.Top:Set(DefaultPosY)
        prioritySettingsPrefs.posX = DefaultPosX
        prioritySettingsPrefs.posY = DefaultPosY
        Prefs.SetToCurrentProfile("AdvancedPriotities", prioritySettingsPrefs)
        Prefs.SavePreferences()
        resetPosition = true
end

the condition is line 802 where the bug occurs.

but i m pretty sure it s due to resolution and coordinate retrieved from
Prefs.GetFromCurrentProfile('options').primary_adapter

it put the resolution 2560x1440 to a table, and i check the x and y position of the window.
This code is designed to prevent out of range position.

I don't reproduce this bug (i use a single monitor). the dual monitor may have an impact on how the resolution is retrieved by the game.
Does it take the resolution of the game ? or the windows system ? that's the key i think.

Be sure i m investigating this. I have a laptop with a dual screen (not the computer i run Faf), i m going to install faf on it and check how it works in debug. i must reproduce.