Black Screen with mod v6 'Advanced Target Priorities EVO'

magge

If I activate the mod v6, I just get a black screen when I start the game. Even when I disable all other mods. Can you have a look, please?

game_24793153.log

Context: https://forum.faforever.com/topic/9019/mod-ui-advanced-target-priorities-evo-presets-management-new-clean-ui-graphics-enhancement-free-layout/8

SealingSatyr511

ok i start to investigate... it works at home. will check it asap

SealingSatyr511

info: Hooked /lua/ui/game/unitview.lua with /mods/advanced target priorities evo/hook/lua/ui/game/unitview.lua
info: Hooked /lua/ui/game/construction.lua with /mods/advanced target priorities evo/hook/lua/ui/game/construction.lua
info: Hooked /lua/ui/game/orders.lua with /mods/advanced target priorities evo/hook/lua/ui/game/orders.lua
info: Hooked /lua/keymap/misckeyactions.lua with /mods/advanced target priorities evo/hook/lua/keymap/misckeyactions.lua
warning: ...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1844): attempt to concatenate field `Preset' (a nil value)
warning: stack traceback:
warning: ...\faforever\1\gamedata\lua.nx2\lua\ui\game\orders.lua(1844): in main chunk

i don t have this bug, thanks for the report. i m checking...

nomads

Thank you for your hard work. I have also encountered a black screen issue, even if only using your MOD and keeping the screen scaling at 100% or 125% . At this point, pressing the HOME button can enter split screen mode, and the FA screen will appear, but the original UI will completely disappear; if select ACU, you will find that your MOD UI is missing, even the original game UI is gone. I can only exit by pressing ALT+F4.

SealingSatyr511

a hotfix should be available very soon.

I found some side effects relative to gameprefs and the preset management.
May occurs at startup when the prioSettings are unknown, nil error that cause crash.
and an uppercase bug on the preset filename. Stogo1_1.lua => stogo1_1.lua.
Also, a part of the safety code was missing.

i checked from scratch, got errors with use cases, critical, but never a black screen.
Actually the fix is ok. it solves the issues.
the code is way more robust now but need another testing iteration.

nomads

- ---Is the following content related to the capitalization issue you mentioned?
- -- from init_faf.lua
- --- Lowers the strings of a hash-based table, crashes when other type of keys are used (integers, for example)
- local function LowerHashTable(t)
- ```
local o = { }
```
- ```
for k, v in t do 
```
- ```
    o[StringLower(k)] = v 
```
- ```
end
```
- ```
return o
```
- end
- -- mods that have been integrated, based on folder name
- local integratedMods = { }
- integratedMods = LowerHashTable(integratedMods)
- -- convert all mod folder name keys to lower case to prevent typos
- deprecatedMods = LowerHashTable(deprecatedMods)
- -- typical FAF packages
- local allowedAssetsNxy = { }
- allowedAssetsNxy = LowerHashTable(allowedAssetsNxy)
- -- typical FA packages
- local allowedAssetsScd = { }
- allowedAssetsScd = LowerHashTable(allowedAssetsScd)

SealingSatyr511

Hot fix is available

https://forum.faforever.com/post/66448

I tested from scratch, fresh mod and default GamePrefs. I don't have issue or error hidden behind a tree.
I hope it solves the game to freeze at startup some player have encountered on fresh install.

Sorry for the inconvenience

nomads

序列 01_1 00_00_00-00_00_30.gif

I just tried the latest version of version 7.

SealingSatyr511

how is your gamePrefs ?
\AppData\Local\Gas Powered Games\Supreme Commander Forged Alliance

the structure should be like :

AdvancedPriotities = {
                windowHeight = 140,
                posY = 912,
                AttackConstructionLeftValue = 495,
                AttackOrdersLeftValue = 1357,
                Preset = 'strogo1_1',
                FactoryConstructionRightValue = 1540,
                buttonLayoutSeparate = {
                    {
                        'false',
                        'ACU',
                        'false',
                        'false',
                        'Bships',
                        'Cruiser'
                    },
                    {
                        'false',
                        'Destros',
                        'ACU',
                        'Factory',
                        'false',
                        'false'
                    },
                    {
                        'Engies',
                        'Arty',
                        'EXP',
                        'false',
                        'ACU',
                        'false'
                    }
                },
                windowWidth = 220,
                hideAbilities = false,
                posX = 2276,
                FactoryConstructionLeftValue = 254,
                showSeparateWindow = true,
                lockSeparateWindow = false,
                FactoryOrdersLeftValue = 1542,
                AttackConstructionRightValue = 1355
            },

nomads

Preset = 'strogo1_1',

This command doesn't seem to be automatically added

SealingSatyr511

Can you add it and have a check ?
i tried multiple scenario where the entries in GamePrefs were missing, and the crud operation works on the preset filename.

nomads

After the instruction is added, it's okay
thank you very much.

SealingSatyr511

if it fix the prb by adding this entry, that mean i must verify the mod pref of the profile and if it is not compliant, delete and rebuilt it on the fly, to prevent any bad old data structure.

nomads

unable to add commands, related to Windows system permissions?

SealingSatyr511

well, i will do a fix to check the gamePrefs as i described. It can occurs some structure corruption after installing wrong update etc...

SealingSatyr511

This post is deleted!

nomads

Take care of yourself, good night

SealingSatyr511

@nomads not sure it was due to that. i prefer do a better control of any existing entries in gameprefs first.

The v7 contains several major fixes also.

SealingSatyr511

Thank you