• Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Login
FAForever Forums
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Login

Legacy client not working

Scheduled Pinned Locked Moved General Discussion
40 Posts 15 Posters 3.4k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • B
    Brutus5000 FAF Server Admin
    last edited by 13 Dec 2020, 19:25

    @Gatsik I ask once more: why don't you publish your changes to Github? Other people might want to build on top of your changes.
    We can make you maintainer of the project and you can build official releases.

    He said, "I've been to the year 3000
    Not much has changed, but they live underwater
    And your great-great-great-granddaughter
    Is playin' FAF, playin' FAF"

    1 Reply Last reply Reply Quote 1
    • D
      Didvul
      last edited by 13 Dec 2020, 20:23

      But they are on Github, aren't they? Because I'm not a programmer and, firstly, I don't want to spoil anything, and secondly, I don't know when I'll stop trying to fix it.

      P.S. Updated the release binary of the previous post from here, so map search should start to work

      1 Reply Last reply Reply Quote 1
      • B
        Brutus5000 FAF Server Admin
        last edited by 13 Dec 2020, 20:38

        Well you started with whats on Github. So obviously it is found by people who are interested in it.
        Also: What's there to spoil? Right now the github version is majorly broken and you have fixes.

        He said, "I've been to the year 3000
        Not much has changed, but they live underwater
        And your great-great-great-granddaughter
        Is playin' FAF, playin' FAF"

        1 Reply Last reply Reply Quote 2
        • T
          ThomasHiatt
          last edited by 14 Dec 2020, 04:28

          For some reason, the leaderboard tab stopped working at some point. It used to just show the leaderboards web page from the FAF website. I think that is the ideal solution since it lets you look at the ladder league standings and stuff from within the client.

          1 Reply Last reply Reply Quote 0
          • D
            Didvul
            last edited by 14 Dec 2020, 04:51

            @Brutus5000 I mean I read the docs, and I'm sure my code is awful inconsistent in terms of these requirements, I didn't use logger as I'm not sure where it is needed, repetitions that probably could've summarized into some classes, etc.
            I can do a pull request so someone who has expertise can review it if that is what you want from me.

            @ThomasHiatt I was thinking about using those internal 'Air scouts', 'Tech 1', ... tabs to rename them and asking api, since the playerDivisionInfo is available here, but probably adding the website would be easier.

            M 1 Reply Last reply 14 Dec 2020, 16:02 Reply Quote 1
            • M
              MazorNoob @Didvul
              last edited by 14 Dec 2020, 16:02

              @Gatsik I took a look at your commits , and as a long-time Python client maintainer I officially bless them as good.

              1 Reply Last reply Reply Quote 2
              • D
                Didvul
                last edited by 16 Dec 2020, 18:47

                • Display the leaderboards web page from the FAF website as leaderboards
                • Newstab: display images and links
                • Vaults tab: items' icons (known or unknown) are always shown

                Unofficial Python client 0.18.13

                Created a pull request so other people who might want to build on top of these changes are able to do this.

                1 Reply Last reply Reply Quote 2
                • B
                  Brutus5000 FAF Server Admin
                  last edited by 22 Dec 2020, 10:03

                  The pull request got merged and officially released by Strogo 🍾

                  He said, "I've been to the year 3000
                  Not much has changed, but they live underwater
                  And your great-great-great-granddaughter
                  Is playin' FAF, playin' FAF"

                  1 Reply Last reply Reply Quote 2
                  • D
                    Didvul
                    last edited by 12 Jan 2021, 20:36

                    I have not enough acquaintances to test it properly (and too dumb to write unit tests), so here it is:

                    Unofficial Python client 0.19.1 omega TMM

                    If it's OK, then I'll do a pull request a little bit later, because I had connection issues today (but also I had the same issues with 0.19.0, so It shouldn't be related to TMM).
                    Anyway, It needs further work.

                    1 Reply Last reply Reply Quote 3
                    • D
                      Didvul
                      last edited by 16 Jan 2021, 17:45

                      • Forbid inviting those who are currently in game to party
                      • Do not send "stop search" command as party guest
                      • Display TMM ratings in the chatter's rank tooltip
                      • Append correct TMM rating at game launch

                      Unofficial Python client 0.19.11 psi TMM

                      1 Reply Last reply Reply Quote 3
                      • First post
                        Last post