Kyro's lobby - updated
-
too bad, it was so much better
-
There is another way to do it. I'll get around to adding file.
Edit. you can redownload using the link. Read the readme carefully.
-
Creative
-
works fine, thanks
-
very creative, but now they don't work Advanced strategic icons...
-
I'll add a separate exception for this extension: https://github.com/FAForever/fa/pull/3627
This will be live this week, I can't say when because I'm quite a bit busy myself.
-
I saw somewhere else that you could name it texturepack.nxt but i didn't try it myself.
-
@macdeffy You can now name it
kyros.nxt- it is accepted with the patch we just released. Please update your guide to prevent confusion. Note that this doesn't mean FAF officially supports the custom lobby - it is still up to its maintainer to keep it compatible.If anyone is interested in improving the lobby - please contact me. There is no need to work on a custom lobby if you can just improve the actual lobby that ships with the game.
-
I'll change it on my end in the meantime. It was my intention to try and port just the layout portion to the regular lobby. I have copied all the new code to kyros where applicable, but properly improving the code or maintaining it to a high enough standard is beyond me.
Majority of backend is same as current lobby, but chat code and layout obviously differs greatly.
Hopefully someone with the proper skillset will take it over, as all i can do is keep it functional since i don't consider myself a developer.
-
it seems that the change has not taken effect yet. kyros.nxt does not load. texturepack.nxt works though.
-
thank you very much! it worked!
-
@macdeffy what about creating a github repository for collaboration? I think, it would be great, if anyone can take part in the development
Maybe it shoud be organization like FAForever. If someone from the base team disappears indefinitely or abandon the project, this will allow the continued support of the mod, until there is at least one member left who can accept changes to the repository. -
FAF does not Officially Support Kyro's Lobby
-
@Rowey it's not question for FAF Team... Interested community can support this alternative lobby.
-
then you need to see it the original creator allows for the code to be added to a git repo & allows for it to be altered with the correct Licensing
-
I'm not really the best person to maintain this anyway. When orig creator didn't update for new UI scaling, i just did it on my own for my own purposes through trial and error. What needs to happen is for someone who knows Lua to rethink Similar functionality with new code that fits the actual Lobby code, so there is no issue with rights.
Jip also has a point that this has too much code to vet, and it's not really a priority when you can just manually add it.
I'm convinced there is a better method for aligning slots for instance, but couldn't figure it out myself.
-
@macdeffy I can add some features into lobby through PRs if needed. However i would recommend not use this lobby mod anymore because it causes problems for others when host has it. It also has tons of bugs, so, just leave it and improve main lobby...
-
I have packed a GitHub project with all current files about KyrO's Lobby, legacy code and the code from OP for whoever wants to tinker around with the code, or simply to save it for legacy/nostalgic reasons:
https://github.com/magge-faf/KyrOs-Lobby
I have used the modified lobby for so many years, it was unfortunate to see that the original developer had abandoned the project for unknown reasons.
The latest Lobby, from OP, will probably have bugs and could lead to unwanted side effects for host and clients. Officially, it is not supported.
Some background about the lobby:
- The lobby.lua file has ~10k lines in total, ~3k were added by KyrO
- KyrO, macdeffy and any other who tinkered with it have not used git. May the force with you if you try to follow all the untracked changes
Fun fact: Chinese language supported was added, and macdeffy added scaling for the GUI as well.
How the development cycled:
KyrO used a version of FAForever's lobby.lua from the year <2017 and modified it by several enhancements and QOL functions. The last time he was active on this project, was on his Google Group, back in 2018. Since then, it broke several times, when FAF updated something on their end.
It got hackish "fixed" by other FAF members who knew a bit about coding and several, different versions for several iterations of other FAF versions were shared via the Forum attachment function from 2018 until today. Yeah, messy.
Coding environment:
This legacy code is not intended for beginners, you will have a very bad experience working with that huge file. If you are interested with LUA, head over to https://www.codecademy.com/learn/learn-lua
However, feel free to ping me if you need further information about this project. I am not familiar with LUA, but happy to help.
Future hopes:
Integration of following three personal favorite QOL features:
- Auto move me to my favorite spot for each specific map, when slot is free.
myslot = function(self, params)- Swap lane players with one click
SwapPlayers = function(slot1, slot2)- The SwapPlayers stuff is directly connected to the entire visualization of the slots, related to the starting points for the players in the map. I think that is one of the harder parts to integrate, because it can break so easily, and the current implementation is incredible hackish. But if you see it once, you never want to go back.
-
oh yeah. i was messing about with the LOC values because originally there were none used by the column labels, but it didn't work for the chinese characters. it was mostly me just seeing if it worked. i had forgotten completely about it and am not even sure the translation is correct.
otherwise thanks for putting up the github. i wasn't really sure how to go about it, or even make use of it, but hopefully this gives others an avenue for fixing it properly.
-
Let UI god be with you someday…
