Where my python coders at?

1

@askaholic Yeah I could probably do that. TBH it actually sounds good. Sometimes I don't have the energy to code but I could still read and review it at those times, and it would still count as XP for python. Lol

You must deceive the enemy, sometimes your allies, but you must always deceive yourself!

0

Well I'm a semi-competent python programmer, so I could lend a hand.
That being said I have literally no experience with servers or networking (didn't even know you'd want to use python for that tbh), so besides spotting very obvious bugs, I might not be of much help.

0

You normally don't have to touch any low level networking stuff. Typical server changes feel like "normal" python, so don't worry about that.

0

Btw. when you open https://github.com/FAForever/server and then press dot key, you get IDE in browser.

1

I did server python work professionally for a few years and still work with it today. I can take a look occasionally, no guarantees I’ll regularly be able to.

0

I just need to get peoples GitHub account names so I can add you to the list of people who I can request for review. So either send me that info or just go and do a review on one of the PR’s then I’ll be able to add you.

Either of these are my top priority right now.
https://github.com/FAForever/server/pull/825
https://github.com/FAForever/server/pull/830

0

@KaletheQuick @CheeseBerry @Aulex Could you guys send me your GitHub names so I can add you as reviewers?

0

I'm ChessBerry on GH: https://github.com/ChessBerry
(I don't know who the guys are that took both the name CheeseBerry and CheeseBerries last month but they certainly are annoying)

0

I already have access https://github.com/cheyans

0

@askaholic yes, I am KaletheQuick.

Sorry for not getting to you sooner.

You must deceive the enemy, sometimes your allies, but you must always deceive yourself!

0

@Askaholic Also no guarantees how often I will be able to at the moment, but you can add https://github.com/Exselsior100

1

Great, thanks! No worries @Exselsior, I’m going to try something new which is to create a reviewers group and then request the whole group for review, so hopefully at least a few people from the group will be able to find time for a quick review.

1

Invites have been sent. You'll need to accept them before GitHub will let me request you as reviewers.

0

@askaholic Just accepted. Don't know how much assistance I will be, but I'll do my best and hopefully learn in the process ❤

You must deceive the enemy, sometimes your allies, but you must always deceive yourself!

0

@askaholic
I may be blind, but I can't find an invite. I assume it should just be in the github notifications?

0

@cheeseberry I got my invite from an email

1

jup it was in my mails, ty!

0

@KaletheQuick @CheeseBerry @Exselsior Please check your email, I requested y’all for a review. Also thanks to @Aulex for reviewing already.

1

@askaholic alright. I actually have a day off next week, and have been brushing up on my python 🙂

You must deceive the enemy, sometimes your allies, but you must always deceive yourself!