FAF replay command format question and parser question

ZLO

@askaholic i think i have found something
parser currently does not distinguish between shift-and no-shift commands
I think i have found how it is written in the replay files

no shift
0x0000100f ├── IssueCommand(GameCommand { entity_ids: [0], id: 0, coordinated_attack_cmd_id: -1, type: Move, arg2: -1, target: Position { x: 240.4617, y: 17.90355, z: 92.60901 }, arg3: 0, formation: Formation { a: 0.8416898, b: 0, c: 0.5399614, d: 0, scale: 1 }, blueprint: "", arg4: 0, arg5: 1, arg6: 1, upgrades: Nil, clear_queue: None })
0x000010f8 ├── IssueCommand(GameCommand { entity_ids: [0], id: 1, coordinated_attack_cmd_id: -1, type: Move, arg2: -1, target: Position { x: 243.4599, y: 17.57368, z: 113.5076 }, arg3: 0, formation: Formation { a: 0.8692136, b: 0, c: 0.4940713, d: 0, scale: 1 }, blueprint: "", arg4: 0, arg5: 1, arg6: 1, upgrades: Nil, clear_queue: None })

shift
0x00000f05 ├── IssueCommand(GameCommand { entity_ids: [0], id: 0, coordinated_attack_cmd_id: -1, type: Move, arg2: -1, target: Position { x: 240.55534, y: 17.91385, z: 92.4321 }, arg3: 0, formation: Formation { a: 0.84133023, b: 0, c: 0.5405215, d: 0, scale: 1 }, blueprint: "", arg4: 0, arg5: 1, arg6: 1, upgrades: Nil, clear_queue: None })
0x00000fd7 ├── IssueCommand(GameCommand { entity_ids: [0], id: 1, coordinated_attack_cmd_id: -1, type: Move, arg2: -1, target: Position { x: 243.38371, y: 17.52357, z: 113.442 }, arg3: 0, formation: Formation { a: 0.99777526, b: 0, c: 0.0666754, d: 0, scale: 1 }, blueprint: "", arg4: 0, arg5: 1, arg6: 1, upgrades: Nil, clear_queue: None })

can't see any difference in parser

with shift
0C 4D 00 01 00 00 00 00 00 00 00 01 00 00 00 FF FF FF FF 02 FF FF FF FF 02 3B 62 73 43 30 94 8C 41 F0 FC E2 42 00 00 00 00 00 33 6E 7F 3F 00 00 00 00 FE 88 88 3D 00 00 00 00 00 00 80 3F 00 00 00 00 00 01 00 00 00 01 00 00 00 02 00 00

no shift 
0C 4D 00 01 00 00 00 00 00 00 00 01 00 00 00 FF FF FF FF 02 FF FF FF FF 02 BC 75 73 43 D5 96 8C 41 AA 03 E3 42 00 00 00 00 00 66 92 5E 3F 00 00 00 00 EA F6 FC 3E 00 00 00 00 00 00 80 3F 00 00 00 00 00 01 00 00 00 01 00 00 00 02 01 00

At the end:
02 00 00
02 01 00

i have found exactly the same behavior in attack commands
point out if i did any mistakes

can anyone update the parser?
i am to bad with programming

Jip

I think you're right, this is what my parser in C# does:

https://github.com/Garanas/cs-fa-replay-library/blob/main/FAForever.Replay/ReplayLoader.cs#L45