Completely customizable hotkeys mod
-
@azath0th Yeah I hear you, it's a good idea. I'll see what I can do. PS: big fan, I stole a lot of your code
-
@nex Haven't looked at that code in detail but I have thought about those previews. I'll check it out when I get there. Implementing it into core is more than I ever imagined but I can see it working. So much to do though, would prefer some help with that to get it right. I'll think about opening up a suggestion on github when I'm done with the proof of concept version and see who's interested. Thanks!
-
@freadyfish stealing code isn't good idea at all. Put the license on top of each file you copied or use directly from mods.
-
@azath0th Ehm you don't have a license file and you leave the copyright field empty? Or am I wrong in assuming you are 4z0t? Otherwise, yes, ofc. Even though I do not understand at all why anyone would copyright a mod. Very lame
-
@freadyfish said in Completely customizable hotkeys mod:
Ehm you don't have a license file and you leave the copyright field empty?
That'd mean you aren't allowed to copy anything from the mod and publish it, without getting approval from the author first, as is explained on the github licensing page for example.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#choosing-the-right-licenseSure it'd be nicer if everyone put a nice license for fair use with credit to the original author, but if the mod author is active you should ask if you can copy stuff or at least credit them for what you copied in your work. (aside from copy pasting singular lines or something)
-
@nex Aaah. Yes. You are right actually. I assumed too much. In @Azath0th case he does have the MIT license on his github repo so I will include that license for any of my releases and all should be fine. For everyone else, just sue me (that's a joke!)
-
You don't have to put any license if you just import required functions from a mod. About license for each mod: I will add these, but there are too many mods for update, it should come one by one. Thanks for pointing.
-
@FreadyFish have you got any progress yet? https://github.com/4z0t/FAF-UI-Mods/blob/dev/aka_v01/mods/AKA/Main.lua
-
@zer0d4y I have completely missed this! Been busy with an OpenRA mod of mine, so no unfortunatelly I didnt do much at all. Barely even played (shameful)
What about you? Any new ideas? Seems like a good start!
-
@FreadyFish It is being integrated https://github.com/FAForever/fa/pull/5755
-
Hey, want to get your thoughts on some further ideas here.
I'm thinking to create a dialog, possibly opened from a new button in the default hotkeys page. From there I imagine a set of tabs for the different contexts, like for engineers or factories selected. In each tab it's possible to create commands for that context, even chain link several commands to run in sequence (for example: select all TML + Group scatter + enter launch mode). In the end you can create a set of finely tuned hotkeys from all possible default hotkeys commands.
As the next step i imagine an import function where users can share their hotkeys either for all or specific contexts. Maybe someone likes my engineer hotkeys, and your factory hotkeys - should be possible to mix. When importing it would be nice to be able to convert between different keyboard layouts (languages) so it gets the same placement.
I think it will be an awesome project, worthy of integration. It would be great to get your help. You in on giving it a try?