Enable wasp projectile impact effects against air units
-
I always found it odd that during air engagements the Wasp projectiles would always just vanish when impacting a target, especially compared to other asf like the Corona which has a very bright explosion on impact.
After playing around in sandbox to see if this was a bug I noticed the wasp's weapon does indeed have an effect made but it only triggers on grounded units. I went and checked the code and the lua seems to be missing FxImpactAirUnit.
I think enabling this weapon effects to play against air units would make it visually more interesting and look less unfinished, especially since it seems to be unintentional.
I made a few short videos as well showcasing the wasp with its effects working on air units. https://imgur.com/a/Qdp9jsf
-
@Jip Make it happen? Or maybe it was removed due to some performance issues or w/e?
-
We can do this, never noticed that the effect was missing
-
Consider it done: https://github.com/FAForever/fa/pull/5066
-
@jip Awesome, thanks! Though I noticed in the PR the effect used was "TAAGinsuHitLand", which only makes a little 2d orange fireball, it seems like it would be used if the beam hit the ground. "TAAGinsuHitUnit" seems more appropriate for hitting another aircraft, making a big blue flash followed by sparks.
-
Ah, my mistake. I'll fix it tomorrow
-
@jip you're all good I appreciate you even taking the time to look at this
-
There we go: https://github.com/FAForever/fa/pull/5079
