Allow watching replays while in queue

If you are watching an old replay during game launch then the launched game will desync because the files could not be updated. This is why you cannot watch replays while in queue

Can probably still get around it using the python client.

Can we allow wathing replays from the current patch then?

@sheikah How does the "watch replay while in lobby" feature work then?

I could swear I have played dozens of games with paused or still running replays in the background without any desyncs happening.

Is that a different case? Was I just lucky?

Watch replay while in lobby -> you x up -> game launches -> correct game version exists since in order to join the lobby you need to have the same version as host.

This doesn't exist in automatching.

If I understand this correctly, this means that what I'm proposing is technically possible, as it works in the lobby, but the implementation for the queue is just not straightforward due to not using the lobby system?

Hmm, if that's the case, can we do what Tagada suggested and allow watching replays of the same version number? That would cover like 90% of use cases already (those being watching the replay of the last game you played or a live replay while you wait)

The reason in lobby works is because the files are already updated and also in use so they can't be changed.

Allowing to run on the current version is possible but also annoying to implement. Would rather move forward with having files for replays and files for games so they are independent, but that is not super high on the priority list at the moment.

Can't we force a download of a patch as you queue? Then it would work the same as you were in the lobby.

It already does update when you hit the queue button. The issue is the replay would then try to update the patch when you play it. And since the files are not in use it would overwrite them

so it should lock files while you are in queue? and that way you would not be able to shoot yourself in the leg?

TA4Life: "At the very least we are not slaves to the UI" | http://www.youtube.com/user/dimatularus | http://www.twitch.tv/zlo_rd

There is a potential that the file lock could prevent the game from launching. But not sure as I have never tested it.

Keeping separate files for replay watching seems less error prone. It will take a while until it's implemented though. As Sheikah said it is not a priority at the moment

Have been playing a bit more tmm, and being able to watch a replay while in queue would make the entire experience so much more enjoyable.

I know it's dangerous in that you can accidentally load the wrong game files and crash, but making it an experimental feature in the settings with some warnings, explaining the danger seems to me preferable to not allowing it at all.

@sheikah said in Allow watching replays while in queue:

The reason in lobby works is because the files are already updated and also in use so they can't be changed.
Allowing to run on the current version is possible but also annoying to implement. Would rather move forward with having files for replays and files for games so they are independent, but that is not super high on the priority list at the moment.

I'd prefer to see the client support having multiple installed versions simultaneously (i.e. store game files under $FAF/$VER/gamedata etc.). This would make it much easier to watch old replays and to try experimental versions.

Sure that is possible from a file storage perspective but doesn't necessarily account for the different mod versions and settings in the game.prefs file which are shared even across versions but can still conflict with each other

Let alone that the game instances lock files, and because of that it can cause the renderer of the game to crash.

A work of art is never finished, merely abandoned

I was launching 10 game instances at a time and it was ok 😉

“Be a yardstick of quality. Some people aren’t used to an environment where excellence is expected.”
— Steve Jobs.
My UI Mods

While I'd love to have a safe, well implemented, and user friendly way to watch replays while in queue, this sounds like a lot of work that's honestly probably quite hard to justify considering what else that time could be used for.

Hence that's not what I'm requesting here.

What I'd like is just an advanced/experimental/hidden setting that allows me to watch replays while in queue at my own risk.

Doing so is already possible if you really want: Leave your TMM party, start the replay, close the client, restart the client, rejoin the TMM party, join the TMM queue.

Similarly, the checks for the already existing watch-replay-while-in-lobby feature is a bit safer than no checks at all, as, while it tries to prevent you from loading incompatible replays sometimes, it doesn't always do so. That's very much fine though, because if you close the offending replay in time, everything runs as you'd expect. (If you don't, the game does crash though.)

So instead of a popup straight up preventing me from starting any replay, even compatible ones, while in queue, I'd suggest an advanced setting that replaces the popup with one that warns me about the potential crash, but then lets me proceed anyway.

I am not willing to implement a feature that is known to lead to potential crashes or desyncs when launching a matchmaker game.

You have framed it as if it would only affect you, but it also affects all the other players you were matched with who had no option. And would result in a failed match for them.

I wonder if there might be a sufficient solution involving adding functionality that basically automatically force quits any local replay instance(s) when you find a match in queue.

pfp credit to gieb