@Askaholic Also no guarantees how often I will be able to at the moment, but you can add https://github.com/Exselsior100
Where my python coders at?
Great, thanks! No worries @Exselsior, I’m going to try something new which is to create a reviewers group and then request the whole group for review, so hopefully at least a few people from the group will be able to find time for a quick review.
Invites have been sent. You'll need to accept them before GitHub will let me request you as reviewers.
@askaholic Just accepted. Don't know how much assistance I will be, but I'll do my best and hopefully learn in the process ️
You must deceive the enemy, sometimes your allies, but you must always deceive yourself!
@askaholic
I may be blind, but I can't find an invite. I assume it should just be in the github notifications?
@KaletheQuick @CheeseBerry @Exselsior Please check your email, I requested y’all for a review. Also thanks to @Aulex for reviewing already.
@KaletheQuick @CheeseBerry @Exselsior @Aulex (or anyone else) review away!
https://github.com/FAForever/server/pull/867
https://github.com/FAForever/server/pull/828
@askaholic alright. I actually have a day off next week, and have been brushing up on my python
You must deceive the enemy, sometimes your allies, but you must always deceive yourself!
Need help from any and all who see this. This is a very important pr for making it so that people who frequently cause matchmaker games to fail will be prevented from queuing for a certain period of time.
https://github.com/FAForever/server/pull/885
It needs to be reviewed and tested. Hopefully I’ll find some time to organize this soonTM.